Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o/snapstate, features, tests: remove snapd-snap experimental feature #14531

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ernestl
Copy link
Collaborator

@ernestl ernestl commented Sep 23, 2024

Remove snapd-snap experimental feature.

Spread test change summary:

  • Removed tests/main/snapd-reexec-snapd-snap/task.yaml:
    • very simplistic test, apart from the install of snapd using snapd-snap experimental feature which is not relevant anymore, the basic check that re-exec to snapd snap works after install is fully covered in tests/main/snapd-reexec/task.yaml
  • Removed tests/main/snapd-snap-transition-experimental-flag/task.yaml:
    • this was largely a duplicate of above tests/main/snapd-reexec-snapd-snap/task.yaml testing the install of snapd using snapd-snap experimental feature
  • Tweaked tests/main/snapd-without-core/task.yaml:
    • to not set snapd-snap experimental feature flag

This feature was replaced by snapd auto-install on classic systems.

JIRA: https://warthogs.atlassian.net/browse/SNAPDENG-32505

CAN ONLY LAND AFTER: #14455

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (2e47491) to head (00cdb9f).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14531      +/-   ##
==========================================
+ Coverage   78.89%   78.95%   +0.06%     
==========================================
  Files        1083     1084       +1     
  Lines      146377   146538     +161     
==========================================
+ Hits       115479   115702     +223     
+ Misses      23695    23647      -48     
+ Partials     7203     7189      -14     
Flag Coverage Δ
unittests 78.95% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernestl ernestl added this to the 2.67 milestone Sep 25, 2024
@ernestl ernestl force-pushed the SNAPDENG-32505_remove_snapd_snap_expiremental_feature branch 3 times, most recently from 7139c1e to e1af200 Compare October 18, 2024 10:11
@ernestl ernestl added the Run nested The PR also runs tests inluded in nested suite label Oct 18, 2024
@ernestl ernestl force-pushed the SNAPDENG-32505_remove_snapd_snap_expiremental_feature branch 2 times, most recently from 0ad5d03 to 85fed59 Compare October 18, 2024 11:19
@ernestl ernestl force-pushed the SNAPDENG-32505_remove_snapd_snap_expiremental_feature branch from 85fed59 to 00cdb9f Compare October 18, 2024 11:46
@ernestl ernestl marked this pull request as ready for review October 18, 2024 11:52
@ernestl
Copy link
Collaborator Author

ernestl commented Oct 21, 2024

Not urgent, may be removed from 2.67 if this or dependency not ready by Weds 23 Oct.

Copy link
Contributor

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants